Skip to content

Update video search list#30

Merged
theScrabi merged 5 commits intoTeamNewPipe:masterfrom
darkon5:master
Sep 20, 2015
Merged

Update video search list#30
theScrabi merged 5 commits intoTeamNewPipe:masterfrom
darkon5:master

Conversation

@darkon5
Copy link
Copy Markdown
Contributor

@darkon5 darkon5 commented Sep 19, 2015

I adapted the search list so it would look nicer. I can only test on my screen, but I think it's an improvement. On my screen I get to see one more video on list.

(I only changed video_item.xml and dimentxt.xml, the rest was automated by Android Studio)

Before
Before

After
After

PD: I'm kind of newbie in this Git and Android Studio stuff. I'll try to keep the weirdness to a minimun.

@darkon5 darkon5 closed this Sep 19, 2015
@darkon5 darkon5 reopened this Sep 19, 2015
@darkon5 darkon5 closed this Sep 19, 2015
@darkon5 darkon5 reopened this Sep 19, 2015
@theScrabi
Copy link
Copy Markdown
Member

Hm ok I'll merge it later. I was also thinking about another change. I want to put the duration on top of the video like the original app does, and then put the creation date where the duration was.

theScrabi added a commit that referenced this pull request Sep 20, 2015
Update video search list
@theScrabi theScrabi merged commit ff30b7d into TeamNewPipe:master Sep 20, 2015
@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Sep 20, 2015

You mean something like this? (the duration needs proper colors and positioning)

screenshot_2015-09-20-13-48-30

@theScrabi
Copy link
Copy Markdown
Member

Hm i had put it in the bottom right corner and mad it transparent like the original. But thats ok to :)

@theScrabi
Copy link
Copy Markdown
Member

Actually i like that :) lets try it out.

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Sep 20, 2015

Well, I was changing it to the bottom right of the thumbnail too xD

screenshot_2015-09-20-14-50-07

Colors can be changed on durationback.xml
(Original white colors -> Stroke: #4fa5d5, BG: #ffffff)

PS: Sorry if I'm slowing you down in the development. I'm learning ASAP about Android dev.

@theScrabi
Copy link
Copy Markdown
Member

You are speeding it up !!! Now i don't need to do it my self. Thanks.

@heineraa heineraa mentioned this pull request Jan 9, 2022
3 tasks
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gcandrade10 pushed a commit to gcandrade10/NewPipe that referenced this pull request Jan 25, 2025
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants