Fixed an issue where the download button would crash the app.#13417
Closed
alexjyong wants to merge 1 commit intoTeamNewPipe:refactorfrom
Closed
Fixed an issue where the download button would crash the app.#13417alexjyong wants to merge 1 commit intoTeamNewPipe:refactorfrom
alexjyong wants to merge 1 commit intoTeamNewPipe:refactorfrom
Conversation
7 tasks
TobiGr
added
bug
Contributor
|
We merged dev into refactor in #13420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This fixes an issue where the download button in
refactorbranch would crash the app when used. The code updates the app to correctly retrieve the menu item inside the download dialog. The previous code was not doing this, causing app crashes.Fixes the following issue(s)
(note, this was fixed in
devbranch in PR Correctly retrieve menu item inside download dialog #13290 for issue 13289. Creating this PR to fix this inrefactorso users do not have to wait for adevmerge intorefactor.)APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence