Partially revert: ErrorActivity: Kotlin-fy buildMarkdown method#13247
Conversation
Author
Before (bugged)Exception
Exceptions (1)
Crash log 1
|
Author
After (fixed)Exception
Crash log
|
ghost
force-pushed
the
crashlog_fix
branch
2 times, most recently
from
5796e1d to
544ce52
Compare
Partially reverts c3dbed5 Fix the bug where collapse container for several crashlogs is created when only one crash log present
TobiGr
added
the
regression
Contributor
|
thank you. Coulld you add tests for |
Author
|
I kinda can't make tests because I face two problems:
Mockito doesn't want to mock it for some reason. Mockk even doesn't want to build/run/import. I can't write the tests, I am too stupid... Sorry |
TobiGr
approved these changes
Feb 19, 2026
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
No problem. We will do it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug where collapse container for several crashlogs is created when only crash log exists
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence