Skip to content

ErrorActivity use normal \n instead of \\n in resource strings#13236

Merged
Stypox merged 1 commit intodevfrom
unknown repository
Feb 12, 2026
Merged

ErrorActivity use normal \n instead of \\n in resource strings#13236
Stypox merged 1 commit intodevfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 11, 2026

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • ErrorActivity use normal \n instead of \\n in resource strings

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Feb 11, 2026
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this was done like this in the first place 😅
Did you test this and confirm that it still works? If yes, this can be merged. Thanks for noticing! :-)

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 12, 2026

Yeah it strangely works ¯\_(ツ)_/¯ I firstly even expected it to not work. And I was checking out to something like ~v0.17.0 and didn't found any other usage even there but I didn't trace to the roots.

I sometimes describe myself as semantic spider (who crawls project(s) and finds some nitty gritty details which for some reason accidentally still alive. Very stupid spider though)

@Stypox
Copy link
Copy Markdown
Member

Stypox commented Feb 12, 2026

Well it's nice you found this nonetheless, will make translator's life easier :-)

@Stypox Stypox merged commit 840664a into TeamNewPipe:dev Feb 12, 2026
6 checks passed
@ghost ghost deleted the error_activity_newlines branch February 12, 2026 12:16
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant