UI bug - theme - broken text colors

[pawlakus]

Checklist

• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.27.6

Steps to reproduce the bug

Set Dark mode (not black. Dark mode)
Refresh subscription
Enter video
Restart app
Refresh subscription
Enter video details or comments

Expected behavior

Text should be white/gray, not black.

Actual behavior

See the screenshot. This happens on video, comments, subscribed video list.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

Issue noticed around 0.27.4? Don't remember exactly.

[natewind]

I had this bug before, but it was rarer, and reloading the app helped (even just reopening the window, without killing the app in settings).

In 0.27.6, it happens every time I open a video.

UPDATE:

1. It happens often but not every time I open a video.
2. It also affects dialogue windows, they’re sometimes in light theme.

[kryptografisch]

same issue. also happens in search result list (title, channel name)

is reproducable for me by searching for a term, then changing via top-right context menu the search result mode/type (all/videos/channels) - > more and more search result entries show black text

[tag27]

Apparently the bug can also occur in black mode.

I already had this error in previous versions, but it became more frequent when the PoToken test version was released.

[pawlakus]

Yes it happens randomly, all over the place, search results, subscribed list, it is not tied to any specific video or channel.

What helps is to navigate to settings and switch theme back and forth few times. That is, for a short time.

[Fs00]

While testing on my end I've noticed a few interesting things:

• the bug starts occurring after opening the details screen of a video, and then propagates to all screens of the app
• disabling the WebView app and restarting NewPipe makes the bug go away entirely

I bet that the WebView used for the PoToken extraction somehow alters the rendering behavior of the entire app.
I'm experiencing this on LineageOS 17.1 (Android 10) running the stock WebView app (v100.0.4896.127).

[AudricV]

I bet that the WebView used for the PoToken extraction somehow alters the rendering behavior of the entire app.

That's exactly the case, WebView seems to update the night mode of the context we pass to it, which is the application one as we need to make the WebView not dependent of an activity context, in order to be used regardless of the playback mode. So this should also apply if you open a license in the app, as licenses are displayed using a WebView too.

Some useful resources from which I tried to apply the one in the top comment, without success: https://stackoverflow.com/questions/57515961/webview-resetting-uimode-and-breaking-dark-theme

As the labels applied to this issue suggest, help is wanted to try to fix the issue, in a proper way.

[Fixer-007]

Same problem for me since 0.27.6 update, affects all newpipe windows more or less.

[Thompson3142]

I have found (a rather ugly) workaround following https://issuetracker.google.com/issues/37124582 . Calling new WebView(this); after ThemeHelper.setTheme(this, ServiceHelper.getSelectedServiceId(this)); in MainActivity seems to fix it. Again, it's really ugly, but it seems to be working (at least for me).