Use native Bundle.toString() implementation

Author: Isira-Seneviratne

app/src/main/java/org/schabi/newpipe/ktx/Bundle.kt

@@ -7,16 +7,3 @@ import java.io.Serializable
 inline fun <reified T : Serializable> Bundle.serializable(key: String?): T? {
     return BundleCompat.getSerializable(this, key, T::class.java)
 }
-
-fun Bundle?.toDebugString(): String {
-    if (this == null) {
-        return "null"
-    }
-    val string = StringBuilder("Bundle{")
-    for (key in this.keySet()) {
-        @Suppress("DEPRECATION") // we want this[key] to return items of any type
-        string.append(" ").append(key).append(" => ").append(this[key]).append(";")
-    }
-    string.append(" }")
-    return string.toString()
-}

app/src/main/java/org/schabi/newpipe/player/PlayerService.java

@@ -37,7 +37,6 @@
 
 import com.google.android.exoplayer2.ext.mediasession.MediaSessionConnector;
 
-import org.schabi.newpipe.ktx.BundleKt;
 import org.schabi.newpipe.player.mediabrowser.MediaBrowserImpl;
 import org.schabi.newpipe.player.mediabrowser.MediaBrowserPlaybackPreparer;
 import org.schabi.newpipe.player.mediasession.MediaSessionPlayerUi;
@@ -126,9 +125,11 @@ public void onCreate() {
     @Override
     public int onStartCommand(final Intent intent, final int flags, final int startId) {
         if (DEBUG) {
-            Log.d(TAG, "onStartCommand() called with: intent = [" + intent
-                    + "], extras = [" + BundleKt.toDebugString(intent.getExtras())
-                    + "], flags = [" + flags + "], startId = [" + startId + "]");
+            final var extras = intent.getExtras();
+            // isEmpty unparcels the bundle
+            final var extrasString = extras != null && !extras.isEmpty() ? extras.toString() : "";
+            Log.d(TAG, "onStartCommand() called with: intent = [" + intent + "], extras = ["
+                    + extrasString + "], flags = [" + flags + "], startId = [" + startId + "]");
         }
 
         // All internal NewPipe intents used to interact with the player, that are sent to the
@@ -269,8 +270,11 @@ protected void attachBaseContext(final Context base) {
     @Override
     public IBinder onBind(final Intent intent) {
         if (DEBUG) {
-            Log.d(TAG, "onBind() called with: intent = [" + intent
-                    + "], extras = [" + BundleKt.toDebugString(intent.getExtras()) + "]");
+            final var extras = intent.getExtras();
+            // isEmpty unparcels the bundle
+            final var extrasString = extras != null && !extras.isEmpty() ? extras.toString() : "";
+            Log.d(TAG, "onBind() called with: intent = [" + intent + "], extras = ["
+                    + extrasString + "]");
         }
 
         if (BIND_PLAYER_HOLDER_ACTION.equals(intent.getAction())) {