Skip to content

Commit c9d273b

Browse files
committed
PlayerHolder: inline setListener
It’s only used in this one place.
1 parent e56307a commit c9d273b

1 file changed

Lines changed: 8 additions & 14 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/helper/PlayerHolder.java

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import android.os.IBinder;
88
import android.util.Log;
99

10-
import androidx.annotation.NonNull;
1110
import androidx.annotation.Nullable;
1211
import androidx.core.content.ContextCompat;
1312

@@ -111,18 +110,6 @@ public void unsetListeners() {
111110
holderListener = null;
112111
}
113112

114-
public void setListener(@NonNull final PlayerServiceEventListener newListener,
115-
@NonNull final PlayerHolderLifecycleEventListener newHolderListener) {
116-
listener = newListener;
117-
holderListener = newHolderListener;
118-
119-
// Force reload data from service
120-
if (player != null) {
121-
holderListener.onServiceConnected(playerService, false);
122-
player.setFragmentListener(internalListener);
123-
}
124-
}
125-
126113
/**
127114
* Helper to handle context in common place as using the same
128115
* context to bind/unbind a service is crucial.
@@ -147,7 +134,14 @@ public void startService(final boolean playAfterConnect,
147134
final PlayerHolderLifecycleEventListener newHolderListener
148135
) {
149136
final Context context = getCommonContext();
150-
setListener(newListener, newHolderListener);
137+
listener = newListener;
138+
holderListener = newHolderListener;
139+
140+
// Force reload data from service
141+
if (player != null) {
142+
holderListener.onServiceConnected(playerService, false);
143+
player.setFragmentListener(internalListener);
144+
}
151145
if (bound) {
152146
return;
153147
}

0 commit comments

Comments
 (0)