Skip to content

Commit fbc222e

Browse files
committed
chore: address feedback
Signed-off-by: Timo Glastra <timo@animo.id>
1 parent 6d0bfc9 commit fbc222e

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

packages/common/lib/functions/CredentialRequestUtil.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { getFormatForVersion } from './FormatUtils';
1111

1212
export function getTypesFromRequest(credentialRequest: CredentialRequest, opts?: { filterVerifiableCredential: boolean }) {
1313
let types: string[] = [];
14-
console.log(credentialRequest);
1514
if ('credential_identifier' in credentialRequest && credentialRequest.credential_identifier) {
1615
throw Error(`Cannot get types from request when it contains a credential_identifier`);
1716
} else if (

packages/common/lib/functions/TypeConversionUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ export function getTypesFromObject(
3737
return undefined;
3838
} else if (typeof subject === 'string') {
3939
return [subject];
40-
} else if ('format' in subject && subject.format !== 'vc+sd-jwt' && 'credential_definition' in subject) {
41-
return getTypesFromObject(subject.credential_definition);
40+
} else if ('credential_definition' in subject) {
41+
return getTypesFromObject(subject.credential_definition as CredentialDefinitionJwtVcJsonLdAndLdpVcV1_0_13 | CredentialDefinitionJwtVcJsonV1_0_13 | JsonLdIssuerCredentialDefinition);
4242
} else if ('types' in subject && subject.types) {
4343
return Array.isArray(subject.types) ? subject.types : [subject.types];
4444
} else if ('type' in subject && subject.type) {

0 commit comments

Comments
 (0)