Merge pull request #106 from Sphereon-Opensource/develop

New release

Author: nklomp

.github/workflows/build-test-on-pr.yml

@@ -16,16 +16,16 @@ jobs:
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '18.18.0'
-      - uses: pnpm/action-setup@v2
+          node-version: '20.x'
+      - uses: pnpm/action-setup@v3
         with:
-          version: 8
+          version: 8.15.7
       - run: pnpm install
       - run: pnpm build
       - name: run CI tests

.github/workflows/build-test-publish-on-push.yml

@@ -30,16 +30,16 @@ jobs:
           - 5432:5432
         options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '18.18.0'
-      - uses: pnpm/action-setup@v2
+          node-version: '20.x'
+      - uses: pnpm/action-setup@v3
         with:
-          version: 8
+          version: 8.15.7
 #      - name: Get yarn cache directory path
 #        id: yarn-cache-dir-path
 #        run: echo "::set-output name=dir::$(yarn cache dir)"

README.md

@@ -7,7 +7,7 @@
 
 [![CI](https://github.com/Sphereon-Opensource/OID4VCI/actions/workflows/build-test-on-pr.yml/badge.svg)](https://github.com/Sphereon-Opensource/OID4VCI/actions/workflows/build-test-on-pr.yml) [![codecov](https://codecov.io/gh/Sphereon-Opensource/OID4VCI/branch/develop/graph/badge.svg)](https://codecov.io/gh/Sphereon-Opensource/OID4VCI) [![NPM Version](https://img.shields.io/npm/v/@sphereon/oid4vci-client.svg)](https://npm.im/@sphereon/oid4vci-client)
 
-_IMPORTANT the packages are still in an early development stage, as such breaking changes are to be expected_
+_IMPORTANT the packages are still in an early development stage, which means that breaking changes are to be expected_
 
 # Background
 
@@ -19,10 +19,10 @@ OpenID4VCI defines an API designated as Credential Endpoint that is used to issu
 corresponding OAuth 2.0 based authorization mechanisms (see [RFC6749]) that a Wallet uses to obtain authorization to
 receive verifiable credentials. W3C formats as well as other Credential formats are supported. This allows existing
 OAuth 2.0 deployments and OpenID Connect OPs (see [OpenID.Core]) to extend their service and become Credential Issuers.
-It also allows new applications built using Verifiable Credentials to utilize OAuth 2.0 as integration and
+It also allows new applications built using Verifiable Credentials to utilize OAuth 2.0 as an integration and
 interoperability layer. This package provides holder/wallet support to interact with OpenID4VCI capable Issuer systems.
 
-Next to the client and issuer, there is also a common package, which has all the types and payloads shared between the client and issuer.
+In addition to the client and issuer, there is also a common package, which has all the types and payloads shared between the client and issuer.
 
 # Packages
 There are 2 main packages in this mono-repository
@@ -34,7 +34,7 @@ The OpenID4VCI client is typically used in wallet type of applications, where th
 ## OpenID for VCI Issuer
 
 The OpenID4VCI issuer is used in issuer type applications, where an organization is issuing the credential(s). More info can be found in the issuer [README](./packages/issuer/README.md). 
-Please not that the Issuer is a library. It has some examples how to run it with REST endpoints. If you however are looking for a full solution we suggest our [SSI SDK](https://github.com/Sphereon-Opensource/ssi-sdk) or the [demo](https://github.com/Sphereon-Opensource/OID4VC-demo)
+Please note that the Issuer is a library. It has some examples on how to run it with REST endpoints. If you are however looking for a full solution we suggest our [SSI SDK](https://github.com/Sphereon-Opensource/ssi-sdk) or the [demo](https://github.com/Sphereon-Opensource/OID4VC-demo)
 
 
 # Flows
@@ -47,9 +47,9 @@ This flow is supported but might need more work, so you might run into issues tr
 
 ## Pre-authorized Code Flow
 
-The pre-authorized code flow assumes the user is using an out of bound mechanism outside the issuance flow to
+The pre-authorized code flow assumes that the user is using an out of bound mechanism outside the issuance flow to
 authenticate first.
 
-The below diagram shows the steps involved in the pre-authorized code flow. Note that wallet inner functionalities (like
-saving VCs) are out of scope for this library. Also This library doesn't involve any functionalities of a VC Issuer
+The below diagram shows the steps involved in the pre-authorized code flow. Note that inner wallet functionalities (like
+saving VCs) are out of scope for this library. Also This library doesn't include any functionalities of a VC Issuer
 ![Flow diagram](https://www.plantuml.com/plantuml/proxy?cache=no&src=https://raw.githubusercontent.com/Sphereon-Opensource/OID4VCI-client/develop/docs/preauthorized-code-flow.puml)

package.json

@@ -37,13 +37,13 @@
     "@types/node": "^18.17.3",
     "codecov": "^3.8.3",
     "jest": "^29.6.2",
-    "lerna": "^7.1.4",
+    "lerna": "^8.1.2",
     "lerna-changelog": "^2.2.0",
     "npm-run-all": "^4.1.5",
-    "prettier": "^3.0.1",
-    "rimraf": "^5.0.1",
-    "ts-jest": "^29.1.1",
-    "typescript": "5.3.3"
+    "prettier": "^3.2.5",
+    "rimraf": "^5.0.5",
+    "ts-jest": "^29.1.2",
+    "typescript": "5.4.5"
   },
   "keywords": [
     "Sphereon",

packages/callback-example/lib/__tests__/issuerCallback.spec.ts

@@ -37,7 +37,7 @@ async function proofOfPossessionCallbackFunction(args: Jwt, kid?: string): Promi
   }
   return await new jose.SignJWT({ ...args.payload })
     .setProtectedHeader({ ...args.header })
-    .setIssuedAt(+new Date())
+    .setIssuedAt(args.payload.iat ?? Math.round(+new Date()/1000))
     .setIssuer(kid)
     .setAudience(args.payload.aud)
     .setExpirationTime('2h')

packages/client/lib/AccessTokenClient.ts

@@ -77,8 +77,8 @@ export class AccessTokenClient {
       metadata: metadata
         ? metadata
         : issuerOpts?.fetchMetadata
-        ? await MetadataClient.retrieveAllMetadata(issuerOpts.issuer, { errorOnNotFound: false })
-        : undefined,
+          ? await MetadataClient.retrieveAllMetadata(issuerOpts.issuer, { errorOnNotFound: false })
+          : undefined,
     });
 
     return this.sendAuthCode(requestTokenURL, accessTokenRequest);

packages/client/lib/CredentialOfferClient.ts

@@ -102,8 +102,8 @@ export class CredentialOfferClient {
       uriTypeProperties: isUri
         ? ['credential_offer_uri']
         : version >= OpenId4VCIVersion.VER_1_0_11
-        ? ['credential_issuer', 'credential_type']
-        : ['issuer', 'credential_type'],
+          ? ['credential_issuer', 'credential_type']
+          : ['issuer', 'credential_type'],
       param,
       version,
     });

packages/client/lib/OpenID4VCIClient.ts

@@ -306,8 +306,9 @@ export class OpenID4VCIClient {
       } else if (!response.successBody) {
         debug(`Access token error. No success body`);
         throw Error(
-          `Retrieving an access token from ${this._state.endpointMetadata
-            ?.token_endpoint} for issuer ${this.getIssuer()} failed as there was no success response body`,
+          `Retrieving an access token from ${
+            this._state.endpointMetadata?.token_endpoint
+          } for issuer ${this.getIssuer()} failed as there was no success response body`,
         );
       }
       this._state.accessTokenResponse = response.successBody;
@@ -428,8 +429,9 @@ export class OpenID4VCIClient {
     } else if (!response.successBody) {
       debug(`Credential request error. No success body`);
       throw Error(
-        `Retrieving a credential from ${this._state.endpointMetadata
-          ?.credential_endpoint} for issuer ${this.getIssuer()} failed as there was no success response body`,
+        `Retrieving a credential from ${
+          this._state.endpointMetadata?.credential_endpoint
+        } for issuer ${this.getIssuer()} failed as there was no success response body`,
       );
     }
     return response.successBody;

packages/client/lib/__tests__/ProofOfPossessionBuilder.spec.ts

@@ -9,7 +9,7 @@ import { IDENTIPROOF_ISSUER_URL } from './MetadataMocks';
 
 const jwt: Jwt = {
   header: { alg: Alg.ES256, kid: 'did:example:ebfeb1f712ebc6f1c276e12ec21/keys/1', typ: 'jwt' },
-  payload: { iss: 'sphereon:wallet', nonce: 'tZignsnFbp', jti: 'tZignsnFbp223', aud: IDENTIPROOF_ISSUER_URL, iat: Date.now() },
+  payload: { iss: 'sphereon:wallet', nonce: 'tZignsnFbp', jti: 'tZignsnFbp223', aud: IDENTIPROOF_ISSUER_URL, iat: Date.now()/1000 },
 };
 
 const kid = 'did:example:ebfeb1f712ebc6f1c276e12ec21/keys/1';

packages/client/lib/__tests__/SdJwt.spec.ts

@@ -43,7 +43,7 @@ const vcIssuer = new VcIssuerBuilder()
         },
         payload: {
           aud: issuerMetadata.credential_issuer,
-          iat: +new Date(),
+          iat: +new Date()/1000,
           nonce: 'a-c-nonce',
         },
       },