fix: txCode fixes #117

Author: nklomp

packages/issuer-rest/lib/OID4VCIServer.ts

@@ -68,7 +68,7 @@ function buildVCIFromEnvironment<DIDDoc extends object>() {
 export type ICreateCredentialOfferURIResponse = {
   uri: string
   userPin?: string
-  tsCode?: TxCode
+  txCode?: TxCode
 }
 
 export interface IGetCredentialOfferEndpointOpts extends ISingleEndpointOpts {

packages/issuer/lib/VcIssuer.ts

@@ -126,7 +126,11 @@ export class VcIssuer<DIDDoc extends object> {
     if (grants?.[PRE_AUTH_GRANT_LITERAL]) {
       preAuthorizedCode = grants?.[PRE_AUTH_GRANT_LITERAL]?.[PRE_AUTH_CODE_LITERAL]
       txCode = grants?.[PRE_AUTH_GRANT_LITERAL]?.tx_code
+
       if (txCode !== undefined) {
+        if (!txCode?.length) {
+          txCode.length = opts.pinLength ?? 4
+        }
         grants[PRE_AUTH_GRANT_LITERAL].tx_code = txCode
       }
       if (!preAuthorizedCode) {
@@ -187,7 +191,8 @@ export class VcIssuer<DIDDoc extends object> {
       lastUpdatedAt,
       status,
       notification_id: v4(),
-      ...(userPin && { userPin }),
+      ...(userPin && { txCode: userPin }), // We used to use userPin according to older specs. We map these onto txCode now. If both are used, txCode in the end wins, even if they are different
+      ...(txCode && { txCode }),
       ...(opts.credentialDataSupplierInput && { credentialDataSupplierInput: opts.credentialDataSupplierInput }),
       credentialOffer,
     }

packages/issuer/lib/functions/CredentialOfferUtils.ts

@@ -158,7 +158,7 @@ export function createCredentialOfferObjectv1_0_11(
   if (opts?.preAuthorizedCode) {
     credential_offer.grants[PRE_AUTH_GRANT_LITERAL] = {
       'pre-authorized_code': opts.preAuthorizedCode,
-      user_pin_required: opts.userPinRequired ? opts.userPinRequired : false,
+      user_pin_required: opts.userPinRequired ?? false,
     }
   } else if (!credential_offer.grants?.authorization_code?.issuer_state) {
     credential_offer.grants = {