chore: add biome

Author: nklomp

.github/workflows/build-test-on-pr.yml

@@ -25,7 +25,7 @@ jobs:
           node-version: '20.x'
       - uses: pnpm/action-setup@v4
         with:
-          version: 9.15.3 # TODO remove later, we are temporary dealing with a broken pnpm version in the CI container
+          version: 10.8.1
       - run: pnpm install
       - run: pnpm build
       - name: run CI tests

.github/workflows/build-test-publish-on-push.yml

@@ -39,7 +39,7 @@ jobs:
           node-version: '20.x'
       - uses: pnpm/action-setup@v4
         with:
-          version: 9.15.3 # TODO remove later, we are temporary dealing with a broken pnpm version in the CI container
+          version: 10.8.1
       - run: pnpm install
       - run: pnpm build
       - name: run integration tests

biome.json

@@ -0,0 +1,48 @@
+{
+	"$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+	"vcs": { "enabled": false, "clientKind": "git", "useIgnoreFile": false },
+	"files": { "ignoreUnknown": false, "ignore": [] },
+	"formatter": {
+		"enabled": true,
+		"useEditorconfig": true,
+		"formatWithErrors": false,
+		"indentStyle": "space",
+		"indentWidth": 2,
+		"lineEnding": "lf",
+		"lineWidth": 150,
+		"attributePosition": "auto",
+		"bracketSpacing": true,
+		"ignore": [
+			"**/dist",
+			"**/coverage",
+			"**/*/node_modules",
+			"packages/siop-oid4vp/lib/schemas"
+		]
+	},
+	"organizeImports": { "enabled": true },
+	"linter": {
+		"enabled": true,
+		"rules": { "recommended": false },
+		"ignore": ["**/node_modules", "**/dist", "**/coverage", "**/jest.js"]
+	},
+	"javascript": {
+		"formatter": {
+			"jsxQuoteStyle": "double",
+			"quoteProperties": "asNeeded",
+			"trailingCommas": "all",
+			"semicolons": "asNeeded",
+			"arrowParentheses": "always",
+			"bracketSameLine": false,
+			"quoteStyle": "single",
+			"attributePosition": "auto",
+			"bracketSpacing": true
+		},
+		"globals": ["BigInt", "vitest", "WebAssembly", "console"]
+	},
+	"overrides": [
+		{
+			"include": ["**/__tests__/**/*.ts"],
+			"linter": { "rules": { "style": { "noNonNullAssertion": "off" } } }
+		}
+	]
+}

package.json

@@ -5,7 +5,7 @@
   "author": "Sphereon",
   "license": "Apache-2.0",
   "private": true,
-  "packageManager": "pnpm@9.15.3",
+  "packageManager": "pnpm@10.8.1",
   "workspaces": [
     "packages/*"
   ],
@@ -18,7 +18,7 @@
     "test:ci": "vitest run --config ./vitest.config.ts --coverage",
     "test": "turbo run test:vitest",
     "test:vitest": "vitest run --config ./vitest.config.ts --coverage",
-    "clean": "rimraf --glob **/dist **/coverage **/pnpm-lock.yaml packages/**/node_modules node_modules packages/**/tsconfig.tsbuildinfo",
+    "clean": "rimraf --glob **/dist **/.turbo **/.tsup **/coverage **/pnpm-lock.yaml packages/**/node_modules node_modules packages/**/tsconfig.tsbuildinfo",
     "publish:latest": "lerna publish --conventional-commits --include-merged-tags --create-release github --yes --dist-tag latest --registry https://registry.npmjs.org",
     "publish:next": "lerna publish --conventional-prerelease --force-publish --canary --no-git-tag-version --include-merged-tags --preid next --pre-dist-tag next --yes --registry https://registry.npmjs.org",
     "publish:unstable": "lerna publish --conventional-prerelease --force-publish --canary --no-git-tag-version --include-merged-tags --preid unstable --pre-dist-tag unstable --yes --registry https://registry.npmjs.org"
@@ -44,13 +44,12 @@
     "@types/node": "^20.17.30",
     "@vitest/coverage-v8": "^3.1.1",
     "npm-run-all": "^4.1.5",
+    "@biomejs/biome": "^1.9.4",
     "prettier": "^3.3.2",
     "rimraf": "^5.0.8",
     "lerna": "^8.2.2",
     "tsup": "^8.4.0",
     "turbo": "^2.5.0",
-    "auto": "^11.3.0",
-    "@auto-it/conventional-commits": "^11.3.0",
     "typescript": "5.8.3",
     "vitest": "^3.1.1"
   },

packages/callback-example/package.json

@@ -2,6 +2,7 @@
   "name": "@sphereon/callback",
   "version": "0.18.2",
   "description": "OpenID 4 Verifiable Credential Issuance issuer callback example",
+  "source": "./src/index.ts",
   "type": "module",
   "main": "./dist/index.cjs",
   "module": "./dist/index.js",
@@ -46,7 +47,10 @@
     "node": ">=20.6"
   },
   "files": [
-    "dist"
+    "src",
+    "dist",
+    "README.md",
+    "LICENSE.md"
   ],
   "keywords": [
     "Sphereon",

packages/client/lib/__tests__/EBSIE2E.spec.test.ts

@@ -7,7 +7,7 @@ import { from } from '@trust/keyto';
 import { fetch } from 'cross-fetch';
 import debug from 'debug';
 import { base64url, importJWK, JWK, SignJWT } from 'jose';
-import * as u8a from 'uint8arrays';
+import { fromString, toString } from 'uint8arrays';
 import { describe, expect, it } from 'vitest';
 
 import { OpenID4VCIClientV1_0_11 } from '..';
@@ -33,7 +33,7 @@ const privateKey = from(jwk, 'jwk').toString('blk', 'private');
 const publicKey = from(jwk, 'jwk').toString('blk', 'public');
 console.log(`Private key: ${privateKey}`);
 console.log(`Public key: ${publicKey}`);
-console.log(`Private key (b64): ${base64url.encode(u8a.fromString(privateKey, 'base16'))}`);
+console.log(`Private key (b64): ${base64url.encode(fromString(privateKey, 'base16'))}`);
 console.log(`JWK (private 2) ${JSON.stringify(toJwk(privateKey, 'Secp256r1', { isPrivateKey: true }))}`);
 console.log(`JWK (public  2) ${JSON.stringify(toJwk(publicKey, 'Secp256r1', { isPrivateKey: false }))}`);
 

packages/client/package.json

@@ -2,6 +2,7 @@
   "name": "@sphereon/oid4vci-client",
   "version": "0.18.2",
   "description": "OpenID for Verifiable Credential Issuance (OpenID4VCI) client",
+  "source": "./src/index.ts",
   "type": "module",
   "main": "./dist/index.cjs",
   "module": "./dist/index.js",
@@ -29,8 +30,8 @@
     "@sphereon/oid4vc-common": "workspace:*",
     "@sphereon/oid4vci-common": "workspace:*",
     "@sphereon/ssi-types": "^0.33",
-    "cross-fetch": "^3.1.8",
-    "debug": "^4.3.5"
+    "cross-fetch": "^4.1.0",
+    "debug": "^4.4.0"
   },
   "devDependencies": {
     "@sphereon/ssi-sdk-ext.key-utils": "^0.23.0",
@@ -45,23 +46,24 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-import": "^2.29.1",
-    "jest": "^29.7.0",
-    "jest-junit": "^16.0.0",
     "jose": "^4.15.9",
     "nock": "^13.5.4",
     "npm-run-all": "^4.1.5",
     "open-cli": "^7.2.0",
     "ts-node": "^10.9.2",
     "typescript": "5.8.3",
-    "uint8arrays": "3.1.1",
+    "uint8arrays": "^5.1.0",
     "uuid": "^9.0.1",
     "vitest": "^3.1.1"
   },
   "engines": {
     "node": ">=20"
   },
   "files": [
-    "dist"
+    "src",
+    "dist",
+    "README.md",
+    "LICENSE.md"
   ],
   "prettier": {
     "singleQuote": true,

packages/common/lib/dpop/DPoP.ts

@@ -1,7 +1,7 @@
 import { jwtDecode } from 'jwt-decode';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
-import * as u8a from 'uint8arrays';
+import { fromString, toString } from 'uint8arrays';
 import { v4 as uuidv4 } from 'uuid';
 
 import { defaultHasher } from '../hasher';
@@ -70,7 +70,7 @@ export async function createDPoP(options: CreateDPoPOpts): Promise<string> {
     throw new Error('expected access token without scheme');
   }
 
-  const ath = jwtPayloadProps.accessToken ? u8a.toString(defaultHasher(jwtPayloadProps.accessToken, 'sha256'), 'base64url') : undefined;
+  const ath = jwtPayloadProps.accessToken ? toString(defaultHasher(jwtPayloadProps.accessToken, 'sha256'), 'base64url') : undefined;
   return createJwtCallback(
     { method: 'jwk', type: 'dpop', alg: jwtIssuer.alg, jwk: jwtIssuer.jwk, dPoPSigningAlgValuesSupported },
     {
@@ -197,7 +197,7 @@ export async function verifyDPoP(
     }
 
     const accessToken = authorizationHeader.replace('DPoP ', '');
-    const expectedAth = u8a.toString(defaultHasher(accessToken, 'sha256'), 'base64url');
+    const expectedAth = toString(defaultHasher(accessToken, 'sha256'), 'base64url');
     if (dPoPPayload.ath !== expectedAth) {
       throw new Error('invalid_dpop_proof. Invalid ath claim');
     }

packages/common/lib/hasher.ts

@@ -1,21 +1,5 @@
-import { HasherSync } from '@sphereon/ssi-types';
-import sha from 'sha.js';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
-import * as u8a from 'uint8arrays';
+import { HasherSync, shaHasher } from '@sphereon/ssi-types';
 
-const supportedAlgorithms = ['sha256', 'sha384', 'sha512'] as const;
-type SupportedAlgorithms = (typeof supportedAlgorithms)[number];
-
-export const defaultHasher: HasherSync = (data, algorithm) => {
-  const sanitizedAlgorithm = algorithm.toLowerCase().replace(/[-_]/g, '');
-  if (!supportedAlgorithms.includes(sanitizedAlgorithm as SupportedAlgorithms)) {
-    throw new Error(`Unsupported hashing algorithm ${algorithm}`);
-  }
-
-  return new Uint8Array(
-    sha(sanitizedAlgorithm as SupportedAlgorithms)
-      .update(typeof data === 'string' ? u8a.fromString(data) : data)
-      .digest(),
-  );
+export const defaultHasher: HasherSync = (data: string | ArrayBuffer, algorithm: string) => {
+  return shaHasher(data, algorithm);
 };

packages/common/lib/jwt/JwkThumbprint.ts

@@ -1,6 +1,4 @@
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
-import * as u8a from 'uint8arrays';
+import { toString } from 'uint8arrays';
 
 import { defaultHasher } from '../hasher';
 import { DigestAlgorithm } from '../types';
@@ -46,7 +44,7 @@ export async function calculateJwkThumbprint(jwk: JWK, digestAlgorithm?: DigestA
     default:
       throw Error('"kty" (Key Type) Parameter missing or unsupported');
   }
-  return u8a.toString(defaultHasher(JSON.stringify(components), algorithm), 'base64url');
+  return toString(defaultHasher(JSON.stringify(components), algorithm), 'base64url');
 }
 
 export async function getDigestAlgorithmFromJwkThumbprintUri(uri: string): Promise<DigestAlgorithm> {