Skip to content

Commit 1856312

Browse files
committed
chore: keep responseRedirectURI in AuthorizationRequestState
1 parent ba2cc33 commit 1856312

5 files changed

Lines changed: 12 additions & 10 deletions

File tree

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
"fix:lint": "biome lint --error-on-warnings",
1414
"fix:prettier": "biome format --write",
1515
"build": "turbo run build",
16-
"test:ci": "vitest run --config ./vitest.config.ts --coverage",
16+
"test:ci": "vitest run --config vitest.config.mts --coverage",
1717
"test": "turbo run test:vitest",
18-
"test:vitest": "vitest run --config ./vitest.config.ts --coverage",
18+
"test:vitest": "vitest run --config vitest.config.mts --coverage",
1919
"clean": "rimraf --glob **/dist **/.turbo **/.tsup **/coverage **/pnpm-lock.yaml packages/**/node_modules node_modules packages/**/tsconfig.tsbuildinfo",
2020
"publish:latest": "lerna publish --conventional-commits --include-merged-tags --create-release github --yes --dist-tag latest --registry https://registry.npmjs.org",
2121
"publish:next": "lerna publish --conventional-prerelease --force-publish --canary --no-git-tag-version --include-merged-tags --preid next --pre-dist-tag next --yes --registry https://registry.npmjs.org",

packages/common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
},
2020
"scripts": {
2121
"build": "tsup --config ../../tsup.config.ts --tsconfig ../../tsconfig.tsup.json",
22-
"test": "vitest run --config ../../vitest.config.ts --coverage"
22+
"test": "vitest run --config ../../vitest.config.mts --coverage"
2323
},
2424
"dependencies": {
2525
"@sphereon/ssi-types": "0.34.1-feature.DIIPv4.245",

packages/siop-oid4vp/lib/__tests__/RP.request.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ describe('RP should', () => {
304304
expect(request.encodedUri).toMatch(expectedUri)
305305
expect(request.requestObjectJwt).toMatch(expectedJwtRegex)
306306

307-
const responseRedirectUri = rp.getResponseRedirectUri({ correlation_id: '1234', state: 'b32f0087fc9816eb813fd11f' })
307+
const responseRedirectUri = await rp.getResponseRedirectUri({ correlation_id: '1234', state: 'b32f0087fc9816eb813fd11f' })
308308
expect(responseRedirectUri).toBe('https://acme.com/1234?state=b32f0087fc9816eb813fd11f')
309309
})
310310
})

packages/siop-oid4vp/lib/rp/RP.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -292,12 +292,14 @@ export class RP {
292292

293293
let state: AuthorizationRequestState
294294
const correlationId = mappings['correlation_id'] ?? mappings['correlationId']
295-
if (correlationId) {
296-
state = await this.sessionManager.getRequestStateByCorrelationId(correlationId, true)
297-
} else {
298-
const stateId = mappings['state']
299-
if (stateId) {
300-
state = await this.sessionManager.getRequestStateByState(stateId, true)
295+
if (this.sessionManager) {
296+
if (correlationId) {
297+
state = await this.sessionManager.getRequestStateByCorrelationId(correlationId, true)
298+
} else {
299+
const stateId = mappings['state']
300+
if (stateId) {
301+
state = await this.sessionManager.getRequestStateByState(stateId, true)
302+
}
301303
}
302304
}
303305

File renamed without changes.

0 commit comments

Comments
 (0)