[Refactor] Consolidate command execution in system.ts#7506
[Refactor] Consolidate command execution in system.ts#7506gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Refactors `captureCommandWithExitCode` and `execCommand` to delegate to `captureOutputWithExitCode` and `exec` respectively. This centralizes the logic for environment setup, working directory handling, and command safety checks, reducing code duplication and improving consistency across execution utilities.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260511101727Caution After installing, validate the version by running |
WHY are these changes introduced?
captureCommandWithExitCodeandexecCommandinpackages/cli-kit/src/public/node/system.tswere manually duplicating the environment setup, directory handling, and error processing logic already present in their array-based counterparts,captureOutputWithExitCodeandexec.WHAT is this pull request doing?
Refactors
captureCommandWithExitCodeandexecCommandto delegate tocaptureOutputWithExitCodeandexecrespectively. This centralizes the logic for:FORCE_COLORbased onshouldDisplayColors().cwd).checkCommandSafetychecks.execaoptions likewindowsHide.How to test your changes?
Run any CLI command that uses these utilities, like
shopify app buildChecklist
PR created automatically by Jules for task 14120344445568562033 started by @gonzaloriestra