Skip to content

Commit cfd1f7d

Browse files
committed
cleanup
1 parent bb1fe89 commit cfd1f7d

4 files changed

Lines changed: 14 additions & 27 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ on:
77
# pull_request:
88
# branches: [ main, master ]
99
env:
10-
AWS_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY }}
11-
AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }}
12-
AWS_REGION: ${{ secrets.AWS_REGION }}
1310
EMAIL: ${{ secrets.EMAIL }}
1411
PASSWORD: ${{ secrets.PASSWORD }}
1512
jobs:
@@ -21,18 +18,12 @@ jobs:
2118
matrix:
2219
base_urls: ['https://magento.softwaretestingboard.com/']
2320
browsers: ['chromium']
24-
greps: ['@LOGIN', '@SIGN_UP', '@SANITY', '@MEN_CATEGORY_SHOPPING']
21+
greps: ['@LOGIN', '@SIGN_UP', '@SANITY', '@MEN_CATEGORY_SHOP']
2522
steps:
2623
- uses: actions/checkout@v4
2724
- uses: actions/setup-node@v4
2825
with:
2926
node-version: lts/*
30-
- name: configure AWS credentials
31-
uses: aws-actions/configure-aws-credentials@v1
32-
with:
33-
aws-access-key-id: ${{ env.AWS_ACCESS_KEY }}
34-
aws-secret-access-key: ${{ env.AWS_SECRET_KEY }}
35-
aws-region: ${{ env.AWS_REGION }}
3627
- name: Install dependencies
3728
run: npm ci
3829
- name: Install Playwright Browsers

helpers/optionalParamsInterfaces/OptionalParams.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,4 @@ export interface ClientSideValiationErrorOptionalParamsInterface {
3232
emptyFieldsIndexes?: number[],
3333
validationErrorsIndexes?: number[],
3434
validationErrorTextList?: string[],
35-
}
36-
37-
export interface UserShippingDetailsParams {
38-
company?: string,
39-
streetAddress?: string,
40-
streetFieldIndex?: number,
41-
city?: string,
42-
state?: string,
43-
postalCode?: string,
44-
country?: string,
45-
phoneNumber?: string,
46-
shippingMethod?: string,
47-
firstname?: string,
48-
lastname?: string
4935
}

pages/LumaMainPage.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ export class LumaMainPage extends BasePage {
6060

6161
public async clickOnShoppingCart() {
6262
await this.clickElement(this.numberOfCartItemsQuantityLocator);
63-
6463
}
6564

6665
/**

pages/checkoutPage/CheckOutShippingPage.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
import { expect } from "@playwright/test";
22
import { LumaMainPage } from "../LumaMainPage";
3-
import { UserShippingDetailsParams } from "../../helpers/optionalParamsInterfaces/OptionalParams";
43

4+
export interface UserShippingDetailsParams {
5+
company?: string,
6+
streetAddress?: string,
7+
streetFieldIndex?: number,
8+
city?: string,
9+
state?: string,
10+
postalCode?: string,
11+
country?: string,
12+
phoneNumber?: string,
13+
shippingMethod?: string,
14+
firstname?: string,
15+
lastname?: string
16+
}
517

618
export class CheckoutShippingPage extends LumaMainPage {
719
private emailFieldLocator = '#customer-email-fieldset #customer-email';
@@ -103,7 +115,6 @@ export class CheckoutShippingPage extends LumaMainPage {
103115
await this.clickElement(signInButton);
104116
await this.fillText(this.signinEmailAddressLocator, email);
105117
await this.fillText(this.signinPasswordLocator, password);
106-
const lastButon = this.page.locator('button', { hasText: 'Sign In' })
107118
await this.clickElement(signInButton.nth(1));
108119
}
109120

0 commit comments

Comments
 (0)