Open
Conversation
dotnet-policy-service
Bot
added
Status:No recent activity
…NC remark Remove the newly-added ArgumentNullException guard for contentUri to avoid introducing a new throw in a previously-permissive code path. The non-null annotation is kept but marked with NULL_INC for future telemetry-guided follow-up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Covers annotation philosophy (non-null bias), PublicAPI.Shipped.txt update rules, NULL_INC escape hatch criteria, and step-by-step migration workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ContentUri maps to the required packageContent field in the NuGet V3 registration API, so null is not expected in practice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nkolev92
force-pushed
the
dev-nkolev92-protocol2
branch
from
264bd08 to
39a08fd
Compare
Add null-forgiving operator on DownloadUri access in test assertions where the value is known non-null from the test setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…stead of null The dependencies parameter is non-null after nullable enablement. These tests don't use dependencies, so Enumerable.Empty<PackageDependency>() is correct. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Progress: NuGet/Home#14851
Description
Continues the NuGet.Protocol nullable annotation work. Removes
#nullable disablefrom 8 more files and annotates public API surfaces.Files migrated
HttpSourceCacheContext.cs–RootTempFoldermadestring?NullSourceCacheContext.cs– fixedWithRefreshCacheTrue()/Clone()to useInstanceproperty instead of_instancefield (avoids returning null before first access)PackageDownloadContext.cs–DirectDownloadDirectory,ClientPolicyContext,PackageSourceMappingmade nullable;directDownloadDirectoryandpackageSourceMappingConfigurationparameters made nullableRemoteSourceDependencyInfo.cs– annotated as non-null;contentUrimarked withNULL_INC(no runtime check added — see note below); fixedEquals(object)which was incorrectly casting toPackageDependencyInfoinstead ofRemoteSourceDependencyInfoSourceCacheContext.cs–Clone()now assigns_generatedTempFoldervia field instead of through theGeneratedTempFolderproperty (which has side effects);Disposeuses captured localSourcePackageDependencyInfo.cs–Source,DownloadUri,PackageHashmade nullable (all optional per XML docs)UserAgent.cs– removed#nullable disable(no annotation changes needed)UserAgentStringBuilder.cs–_vsInfo,_osInfo,_ciInfofields andWithVisualStudioSKUparameter made nullableNULL_INC note
RemoteSourceDependencyInfo.ContentUriis annotated as non-null (string!) in the public API, but no runtimeArgumentNullExceptionguard is added in the constructor. This property maps to thepackageContentfield in the NuGet V3 registration API, which is required by protocol — so null is not expected in practice. However, since the previous code silently accepted null and we lack telemetry to be certain no caller passes it, a runtime throw is deferred. The property carries aNULL_INCXML remark to track this.Bug fix
RemoteSourceDependencyInfo.Equals(object)was casting toPackageDependencyInfoinstead ofRemoteSourceDependencyInfo, meaning it always returned false for valid comparisons.PR Checklist