add user-agent header

Author: parfenovvs

pkg/config/sysinfo.go

@@ -0,0 +1,71 @@
+package config
+
+import (
+	"fmt"
+	"os/exec"
+	"runtime"
+	"strings"
+	"sync"
+)
+
+var (
+	cachedUserAgent string
+	userAgentOnce   sync.Once
+)
+
+// GetKernelVersion returns the Linux kernel version using uname -r
+func GetKernelVersion() string {
+	cmd := exec.Command("uname", "-r")
+	output, err := cmd.Output()
+	if err != nil {
+		return "unknown"
+	}
+	return strings.TrimSpace(string(output))
+}
+
+// GetDistroName returns the Linux distribution name
+func GetDistroName() string {
+	// Try to get distro name from lsb_release
+	cmd := exec.Command("lsb_release", "-ds")
+	output, err := cmd.Output()
+	if err == nil {
+		distro := strings.TrimSpace(string(output))
+		// Remove quotes if present
+		distro = strings.Trim(distro, "\"")
+		return distro
+	}
+
+	// Fallback to uname -o
+	cmd = exec.Command("uname", "-o")
+	output, err = cmd.Output()
+	if err != nil {
+		return "Linux"
+	}
+	return strings.TrimSpace(string(output))
+}
+
+// GetArchitecture returns the CPU architecture
+func GetArchitecture() string {
+	return runtime.GOARCH
+}
+
+// GetUserAgent constructs the user agent string according to the template:
+// Malwarebytes Privacy/$VERSION_NAME (github.com/Malwarebytes/mbvpn-linux; Build: $VERSION_NAME; $LINUX_DISTRO_NAME $KERNEL_VERSION $ARCH)
+func GetUserAgent(productVersion string) string {
+	userAgentOnce.Do(func() {
+		distro := GetDistroName()
+		kernel := GetKernelVersion()
+		arch := GetArchitecture()
+
+		cachedUserAgent = fmt.Sprintf(
+			"Malwarebytes Privacy/%s (github.com/Malwarebytes/mbvpn-linux; Build: %s; %s %s %s)",
+			productVersion,
+			productVersion,
+			distro,
+			kernel,
+			arch,
+		)
+	})
+
+	return cachedUserAgent
+}

pkg/config/sysinfo_test.go

@@ -0,0 +1,114 @@
+package config
+
+import (
+	"strings"
+	"testing"
+)
+
+func TestGetKernelVersion(t *testing.T) {
+	version := GetKernelVersion()
+	if version == "" {
+		t.Error("Expected non-empty kernel version")
+	}
+	if version == "unknown" {
+		t.Log("Warning: Could not determine kernel version")
+	}
+	t.Logf("Kernel version: %s", version)
+}
+
+func TestGetDistroName(t *testing.T) {
+	distro := GetDistroName()
+	if distro == "" {
+		t.Error("Expected non-empty distro name")
+	}
+	t.Logf("Distro name: %s", distro)
+}
+
+func TestGetArchitecture(t *testing.T) {
+	arch := GetArchitecture()
+	if arch == "" {
+		t.Error("Expected non-empty architecture")
+	}
+	// Common architectures
+	validArchs := []string{"amd64", "386", "arm64", "arm", "ppc64le", "s390x"}
+	isValid := false
+	for _, valid := range validArchs {
+		if arch == valid {
+			isValid = true
+			break
+		}
+	}
+	if !isValid {
+		t.Logf("Warning: Unusual architecture: %s", arch)
+	}
+	t.Logf("Architecture: %s", arch)
+}
+
+func TestGetUserAgent(t *testing.T) {
+	productVersion := "5.14.0"
+	userAgent := GetUserAgent(productVersion)
+
+	if userAgent == "" {
+		t.Fatal("Expected non-empty user agent")
+	}
+
+	// Verify format: Malwarebytes Privacy/VERSION (github.com/Malwarebytes/mbvpn-linux; Build: VERSION; DISTRO KERNEL ARCH)
+	if !strings.HasPrefix(userAgent, "Malwarebytes Privacy/"+productVersion) {
+		t.Errorf("Expected user agent to start with 'Malwarebytes Privacy/%s', got: %s", productVersion, userAgent)
+	}
+
+	if !strings.Contains(userAgent, "github.com/Malwarebytes/mbvpn-linux") {
+		t.Error("Expected user agent to contain 'github.com/Malwarebytes/mbvpn-linux'")
+	}
+
+	if !strings.Contains(userAgent, "Build: "+productVersion) {
+		t.Errorf("Expected user agent to contain 'Build: %s'", productVersion)
+	}
+
+	t.Logf("User agent: %s", userAgent)
+
+	// Test caching - should return same value
+	userAgent2 := GetUserAgent(productVersion)
+	if userAgent != userAgent2 {
+		t.Error("Expected cached user agent to match first call")
+	}
+}
+
+func TestGetUserAgentFormat(t *testing.T) {
+	productVersion := "5.14.0"
+	userAgent := GetUserAgent(productVersion)
+
+	// Verify structure
+	parts := strings.Split(userAgent, " (")
+	if len(parts) != 2 {
+		t.Fatalf("Expected user agent to have format 'PREFIX (DETAILS)', got: %s", userAgent)
+	}
+
+	prefix := parts[0]
+	if prefix != "Malwarebytes Privacy/"+productVersion {
+		t.Errorf("Expected prefix 'Malwarebytes Privacy/%s', got: %s", productVersion, prefix)
+	}
+
+	details := strings.TrimSuffix(parts[1], ")")
+	detailParts := strings.Split(details, "; ")
+	if len(detailParts) != 3 {
+		t.Errorf("Expected 3 detail parts separated by '; ', got %d parts: %v", len(detailParts), detailParts)
+	}
+
+	// Check first detail part
+	if detailParts[0] != "github.com/Malwarebytes/mbvpn-linux" {
+		t.Errorf("Expected first detail 'github.com/Malwarebytes/mbvpn-linux', got: %s", detailParts[0])
+	}
+
+	// Check second detail part
+	if !strings.HasPrefix(detailParts[1], "Build: ") {
+		t.Errorf("Expected second detail to start with 'Build: ', got: %s", detailParts[1])
+	}
+
+	// Check third detail part has distro, kernel, and arch
+	systemInfo := detailParts[2]
+	systemParts := strings.Fields(systemInfo)
+	if len(systemParts) < 2 {
+		t.Errorf("Expected system info to have at least distro and kernel, got: %s", systemInfo)
+	}
+}

pkg/remote/holocron.go

@@ -358,6 +358,7 @@ func (api *DefaultHolocron) doRequest(installationToken string, body *map[string
 	}
 
 	request.Header.Set("X-Device-Bearer", fmt.Sprintf("%s|%s", installationToken, machineId))
+	request.Header.Set("User-Agent", config.GetUserAgent(productVersion))
 
 	reqDump, err := httputil.DumpRequest(request, true)
 	if err != nil {