Fix hanging system image creation if multiple threads are set (#1042)

* Fix hanging system image creation if multiple threads are set

Make sure, that the final system image is built single-threaded and
override any values set by "-t", "--threads" in sysimage_build_args`
or provided via JULIA_NUM_THREADS.
This is needed until the underlying bug is fixed (see #963 and especially
#990 containing a `git bisect` to the commit introducing the problem)

Fixes #963 and #990

* Include the whole issue URL

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

---------

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>

Author: PatrickHaecker

src/PackageCompiler.jl

@@ -462,10 +462,15 @@ function create_sysimg_object_file(object_file::String,
     write(outputo_file, julia_code)
     # Read the input via stdin to avoid hitting the maximum command line limit
 
-        cmd = `$(get_julia_cmd()) --cpu-target=$cpu_target $sysimage_build_args
-            --sysimage=$base_sysimage --project=$project --output-o=$(object_file)
-            $outputo_file`
-        @debug "running $cmd"
+    # Make sure, that the final system image is built single-threaded and
+    # override any values set by "-t", "--threads" in `sysimage_build_args`
+    # or provided via JULIA_NUM_THREADS.
+    # This is needed until the underlying bug is fixed (see https://github.com/JuliaLang/PackageCompiler.jl/issues/963 and especially
+    # https://github.com/JuliaLang/PackageCompiler.jl/issues/990 containing a `git bisect` to the commit introducing the problem)
+    cmd = `$(get_julia_cmd()) --cpu-target=$cpu_target $sysimage_build_args
+        --sysimage=$base_sysimage --project=$project --output-o=$(object_file)
+        --threads=1 $outputo_file`
+    @debug "running $cmd"
 
     non = incremental ? "" : "non"
     spinner = TerminalSpinners.Spinner(msg = "PackageCompiler: compiling $(non)incremental system image")