Skip to content

Commit dda5cad

Browse files
tejas0077Tejas Saubhage
tejas0077
and
Tejas Saubhage
authored
Fix finding title HTML encoding inconsistency in All Findings view fi… (#14524)
* Fix finding title HTML encoding inconsistency in All Findings view fixes #14514 * Fix HTML encoding of special characters in finding titles across all templates --------- Co-authored-by: Tejas Saubhage <tsaubhage0007@gmail.com>
1 parent b03b315 commit dda5cad

9 files changed

Lines changed: 10 additions & 10 deletions

‎dojo/templates/dojo/add_findings_as_accepted.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
</td>
1717
<td>
1818
{% if finding.title %}
19-
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars_html:60 }}</a>
19+
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars:60 }}</a>
2020
{% else %}
2121
<a title="{{ finding.id }}" href="{% url 'view_finding' finding.id %}">{{ finding.id }}</a>
2222
{% endif %}

‎dojo/templates/dojo/breadcrumbs/finding_breadcrumb.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<ol class="breadcrumb">
44
<li><a data-toggle="tooltip" data-placement="top" title="Engagement" href="{% url 'view_engagement' finding.test.engagement.id %}">{{finding.test.engagement.name}}</a></li>
55
<li><a data-toggle="tooltip" data-placement="top" title="Test" href="{% url 'view_test' finding.test.id %}">{{finding.test}}</a></li>
6-
<li><a data-toggle="tooltip" data-placement="top" title="Finding" href="{% url 'view_finding' finding.id %}">{{finding.title|truncatechars_html:60}}</a></li>
6+
<li><a data-toggle="tooltip" data-placement="top" title="Finding" href="{% url 'view_finding' finding.id %}">{{finding.title|truncatechars:60}}</a></li>
77
{% if product_tab.title %}
88
<li class="breadcrumb-item active" aria-current="page">{{product_tab.title}}</li>
99
{% endif %}

‎dojo/templates/dojo/finding_related_row.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
</span>
2020
</td>
2121
<td>
22-
<a title="{{ similar_finding.title }}" href="{% url 'view_finding' similar_finding.id %}">{{ similar_finding.title|truncatechars_html:80 }}</a>
22+
<a title="{{ similar_finding.title }}" href="{% url 'view_finding' similar_finding.id %}">{{ similar_finding.title|truncatechars:80 }}</a>
2323
{% if similar_finding.tags %}
2424
<small>
2525
{% include "dojo/snippets/tags.html" with tags=similar_finding.tags.all %}

‎dojo/templates/dojo/findings_list_snippet.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ <h3 class="has-filters">
543543
</td>
544544
<td>
545545
{% if finding.title %}
546-
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars_html:60 }}</a>
546+
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars:60 }}</a>
547547
{% else %}
548548
<a title="{{ finding.id }}" href="{% url 'view_finding' finding.id %}">{{ finding.id }}</a>
549549
{% endif %}

‎dojo/templates/dojo/metrics.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ <h3>{% trans "Metric Counts" %}</h3>
554554
{{ finding.epss_percentile|format_epss }}
555555
</td>
556556
<td><a href="{% url 'view_finding' finding.id %}"
557-
title="{{ finding.title }}">{{ finding.title|truncatechars_html:20 }}</a>
557+
title="{{ finding.title }}">{{ finding.title|truncatechars:20 }}</a>
558558
</td>
559559
<td class="text-right">{{ finding.age }}</td>
560560
<td>{{ finding.status }}</td>

‎dojo/templates/dojo/request_report.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ <h3 class="has-filters">
7979
{% for finding in paged_findings %}
8080
<tr>
8181
<td>
82-
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars_html:50 }}</a>
82+
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars:50 }}</a>
8383
{% include "dojo/snippets/tags.html" with tags=finding.tags.all %}
8484
</td>
8585
<td class="nowrap">{{ finding.date }}</td>

‎dojo/templates/dojo/templates.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,15 +79,15 @@ <h3 class="has-filters">
7979
{% if add_from_template %}
8080
<a href="{% url 'add_finding_from_template' tid finding.id %}"
8181
class="template-popover" data-placement="auto bottom" data-toggle="popover"
82-
data-trigger="hover" title="{{ finding.title|truncatechars_html:100 }}"
82+
data-trigger="hover" title="{{ finding.title|truncatechars:100 }}"
8383
data-content="{{ finding.description|truncatechars_html:500 }}">
8484
{{ finding.title }}
8585
{% include "dojo/snippets/tags.html" with tags=finding.tags.all %}
8686
</a>
8787
{% elif apply_template %}
8888
<a href="{% url 'choose_finding_template_options' finding.id fid %}"
8989
class="template-popover" data-placement="auto bottom" data-toggle="popover"
90-
data-trigger="hover" title="{{ finding.title|truncatechars_html:100 }}"
90+
data-trigger="hover" title="{{ finding.title|truncatechars:100 }}"
9191
data-content="{{ finding.description|truncatechars_html:500 }}">
9292
{{ finding.title }}
9393
{% include "dojo/snippets/tags.html" with tags=finding.tags.all %}

‎dojo/templates/dojo/view_risk_acceptance.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ <h3>Findings Accepted</h3>
185185
{{ finding.epss_percentile|format_epss }}
186186
</td>
187187
<td><a href="{% url 'view_finding' finding.id %}"
188-
title="{{ finding.title }}">{{ finding.title|truncatechars_html:140 }}</a></td>
188+
title="{{ finding.title }}">{{ finding.title|truncatechars:140 }}</a></td>
189189
<td>{{ finding.date }}</td>
190190
<td>{{ finding.active }}</td>
191191

‎dojo/templates/dojo/view_test.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1145,7 +1145,7 @@ <h4 class="has-filters">
11451145
</td>
11461146
<td>
11471147
{% if finding.title %}
1148-
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars_html:60 }}</a>
1148+
<a title="{{ finding.title }}" href="{% url 'view_finding' finding.id %}">{{ finding.title|truncatechars:60 }}</a>
11491149
{% else %}
11501150
<a title="{{ finding.id }}" href="{% url 'view_finding' finding.id %}">{{ finding.id }}</a>
11511151
{% endif %}

0 commit comments

Comments
 (0)