Fix remaining dojo_dispatch_task call sites

- Avoid passing manager/task attributes via instance
  (use class task objects to ensure .si() is available)
- Stop dispatching non-task jira_helper.push_to_jira through dojo_dispatch_task;
  call it directly and let it dispatch the underlying celery tasks

Author: valentijnscholten

dojo/finding_group/views.py

@@ -16,7 +16,6 @@
 from dojo.authorization.authorization import user_has_permission_or_403
 from dojo.authorization.authorization_decorators import user_is_authorized
 from dojo.authorization.roles_permissions import Permissions
-from dojo.celery_dispatch import dojo_dispatch_task
 from dojo.filters import (
     FindingFilter,
     FindingFilterWithoutObjectLookups,
@@ -101,7 +100,7 @@ def view_finding_group(request, fgid):
                 elif not finding_group.has_jira_issue:
                     jira_helper.finding_group_link_jira(request, finding_group, jira_issue)
             elif push_to_jira:
-                dojo_dispatch_task(jira_helper.push_to_jira, finding_group, sync=True)
+                jira_helper.push_to_jira(finding_group, sync=True)
 
             finding_group.save()
             return HttpResponseRedirect(reverse("view_test", args=(finding_group.test.id,)))
@@ -201,7 +200,7 @@ def push_to_jira(request, fgid):
 
         # it may look like success here, but the push_to_jira are swallowing exceptions
         # but cant't change too much now without having a test suite, so leave as is for now with the addition warning message to check alerts for background errors.
-        if dojo_dispatch_task(jira_helper.push_to_jira, group, sync=True):
+        if jira_helper.push_to_jira(group, sync=True):
             messages.add_message(
                 request,
                 messages.SUCCESS,

dojo/importers/base_importer.py

@@ -946,7 +946,7 @@ def mitigate_finding(
         if settings.V3_FEATURE_LOCATIONS:
             # Mitigate the location statuses
             dojo_dispatch_task(
-                self.location_manager.mitigate_location_status,
+                LocationManager.mitigate_location_status,
                 finding.locations.all(),
                 self.user,
                 kwuser=self.user,
@@ -956,7 +956,7 @@ def mitigate_finding(
             # TODO: Delete this after the move to Locations
             # Mitigate the endpoint statuses
             dojo_dispatch_task(
-                self.endpoint_manager.mitigate_endpoint_status,
+                EndpointManager.mitigate_endpoint_status,
                 finding.status_finding.all(),
                 self.user,
                 kwuser=self.user,