Skip to content

Commit 8447e5c

Browse files
committed
Update announcement banner tests to check for data-source attribute
1 parent 1f4c6f0 commit 8447e5c

2 files changed

Lines changed: 18 additions & 18 deletions

File tree

tests/announcement_banner_test.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def disable_announcement(self):
4141
def test_create_announcement(self):
4242
driver = self.driver
4343
driver.get(self.base_url)
44-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
44+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
4545

4646
text = "Big important announcement, definitely pay attention!"
4747
self.enable_announcement(text, dismissable=False, style=self.type)
@@ -56,7 +56,7 @@ def test_create_announcement(self):
5656
def test_create_dismissable_announcement(self):
5757
driver = self.driver
5858
driver.get(self.base_url)
59-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
59+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
6060

6161
text = "Big important announcement, definitely pay don't dismiss this one."
6262
self.enable_announcement(text, dismissable=True, style=self.type)
@@ -77,7 +77,7 @@ def test_create_dismissable_announcement(self):
7777
def test_dismissing_announcement_does_not_dismiss_for_others(self):
7878
driver = self.driver
7979
driver.get(self.base_url)
80-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
80+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
8181

8282
text = "Everyone sees this, right?"
8383
self.enable_announcement(text, dismissable=True, style=self.type)
@@ -103,7 +103,7 @@ def test_dismissing_announcement_does_not_dismiss_for_others(self):
103103
def test_announcement_ui_disabled_when_set(self):
104104
driver = self.driver
105105
driver.get(self.base_url)
106-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
106+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
107107

108108
text = "The most important announcement of the year."
109109
self.enable_announcement(text, dismissable=False, style=self.type)
@@ -121,7 +121,7 @@ def test_announcement_ui_disabled_when_set(self):
121121
def test_announcement_empty_after_removal(self):
122122
driver = self.driver
123123
driver.get(self.base_url)
124-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
124+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
125125

126126
text = "Surely no-one would delete this announcement quickly"
127127
self.enable_announcement(text, dismissable=False, style=self.type)
@@ -139,7 +139,7 @@ def test_announcement_empty_after_removal(self):
139139
def test_html_announcement(self):
140140
driver = self.driver
141141
driver.get(self.base_url)
142-
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner"))
142+
self.assertFalse(self.is_element_by_css_selector_present(".announcement-banner:not([data-source])"))
143143

144144
text = "Links in announcements? <a href='https://github.com/DefectDojo/django-DefectDojo' style='color: #224477;' target='_blank'>you bet!</a>"
145145
self.enable_announcement(text, dismissable=False, style=self.type)

unittests/test_importers_performance.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ def test_import_reimport_reimport_performance_pghistory_async(self):
576576

577577
self._import_reimport_performance(
578578
expected_num_queries1=146,
579-
expected_num_async_tasks1=1,
579+
expected_num_async_tasks1=2,
580580
expected_num_queries2=124,
581581
expected_num_async_tasks2=1,
582582
expected_num_queries3=37,
@@ -599,8 +599,8 @@ def test_import_reimport_reimport_performance_pghistory_no_async(self):
599599
testuser.usercontactinfo.save()
600600

601601
self._import_reimport_performance(
602-
expected_num_queries1=155,
603-
expected_num_async_tasks1=1,
602+
expected_num_queries1=161,
603+
expected_num_async_tasks1=2,
604604
expected_num_queries2=133,
605605
expected_num_async_tasks2=1,
606606
expected_num_queries3=46,
@@ -624,8 +624,8 @@ def test_import_reimport_reimport_performance_pghistory_no_async_with_product_gr
624624
self.system_settings(enable_product_grade=True)
625625

626626
self._import_reimport_performance(
627-
expected_num_queries1=165,
628-
expected_num_async_tasks1=3,
627+
expected_num_queries1=171,
628+
expected_num_async_tasks1=4,
629629
expected_num_queries2=143,
630630
expected_num_async_tasks2=3,
631631
expected_num_queries3=50,
@@ -725,9 +725,9 @@ def test_deduplication_performance_pghistory_async(self):
725725

726726
self._deduplication_performance(
727727
expected_num_queries1=81,
728-
expected_num_async_tasks1=1,
729-
expected_num_queries2=72,
730-
expected_num_async_tasks2=1,
728+
expected_num_async_tasks1=2,
729+
expected_num_queries2=69,
730+
expected_num_async_tasks2=2,
731731
check_duplicates=False, # Async mode - deduplication happens later
732732
)
733733

@@ -744,8 +744,8 @@ def test_deduplication_performance_pghistory_no_async(self):
744744
testuser.usercontactinfo.save()
745745

746746
self._deduplication_performance(
747-
expected_num_queries1=90,
748-
expected_num_async_tasks1=1,
749-
expected_num_queries2=188,
750-
expected_num_async_tasks2=1,
747+
expected_num_queries1=96,
748+
expected_num_async_tasks1=2,
749+
expected_num_queries2=191,
750+
expected_num_async_tasks2=2,
751751
)

0 commit comments

Comments
 (0)