Skip to content

Commit 0b9004b

Browse files
Maffoochclaude
andauthored
Add authorization check to link_engagement action (#14504)
The link_engagement endpoint in QuestionnaireEngagementSurveyViewSet was missing a permission check on the target engagement. Added user_has_permission_or_403 with Engagement_Edit to ensure the requesting user is authorized before linking. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b101f03 commit 0b9004b

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

dojo/api_v2/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3451,6 +3451,8 @@ def link_engagement(self, request, pk, engagement_id):
34513451
engagement_survey = self.get_object()
34523452
# Safely get the engagement
34533453
engagement = get_object_or_404(Engagement.objects, pk=engagement_id)
3454+
# Verify the user has permission to edit the engagement
3455+
user_has_permission_or_403(request.user, engagement, Permissions.Engagement_Edit)
34543456
# Link the engagement
34553457
answered_survey, _ = Answered_Survey.objects.get_or_create(engagement=engagement, survey=engagement_survey)
34563458
# Send a favorable response

0 commit comments

Comments
 (0)