Skip to content

Commit f5bfea0

Browse files
committed
Simplify comments in camera config tests
Clean up and shorten comments in tests/gui/camera_config/test_cam_dialog_e2e.py: remove parenthetical notes about expected failures tied to implementation details and replace them with concise, direct expectations. No functional test logic changed.
1 parent 83d1edc commit f5bfea0

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

tests/gui/camera_config/test_cam_dialog_e2e.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -463,8 +463,7 @@ def slow_detect(backend, max_devices=10, should_cancel=None, progress_cb=None, *
463463
qtbot.waitUntil(lambda: dialog._is_scan_running(), timeout=1000)
464464
qtbot.waitUntil(lambda: dialog.scan_cancel_btn.isVisible(), timeout=1000)
465465

466-
# EXPECTATION: remove button should be enabled even during scan
467-
# (This will fail until _update_button_states is changed to not block remove/move during scan)
466+
# Remove button should be enabled even during scan
468467
qtbot.waitUntil(lambda: dialog.remove_camera_btn.isEnabled(), timeout=1000)
469468

470469
# Remove the selected active camera during scan
@@ -512,7 +511,6 @@ def test_ok_updates_internal_multicamera_settings(dialog, qtbot):
512511
assert len(emitted.cameras) == 2
513512

514513
# Check: internal source-of-truth must match accepted state
515-
# (This will fail until _on_ok_clicked updates self._multi_camera_settings)
516514
assert dialog._multi_camera_settings is not None
517515
assert len(dialog._multi_camera_settings.cameras) == 2
518516

0 commit comments

Comments
 (0)