Skip to content

Commit 16b0d2a

Browse files
committed
Count unique cameras when starting multi-camera
Previously _expected_cameras was set to len(active_settings), which could overcount when multiple CameraSettings referred to the same physical camera. This change computes a set of unique camera IDs (via get_camera_id) and sets _expected_cameras to its length, ensuring duplicates aren't double-counted.
1 parent 76d9a30 commit 16b0d2a

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

dlclivegui/services/multi_camera_controller.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ def start(self, camera_settings: list[CameraSettings]) -> None:
158158
self._timestamps.clear()
159159
self._started_cameras.clear()
160160
self._failed_cameras.clear()
161-
self._expected_cameras = len(active_settings)
161+
162+
unique_ids = {get_camera_id(s) for s in active_settings}
163+
self._expected_cameras = len(unique_ids)
162164

163165
for settings in active_settings:
164166
self._start_camera(settings)

0 commit comments

Comments
 (0)